-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69157/
-----------------------------------------------------------
(Updated Nov. 20, 2018, 6:50 p.m.)
Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
Changes
-------
Addressed comment from Chun.
Bugs: MESOS-8403
https://issues.apache.org/jira/browse/MESOS-8403
Repository: mesos
Description
-------
The handling of offer operation updates introduced in `c946615ec6d`
made use of an update's `latest_status` without making sure that any
value was set. This could lead to situation where an uninitialized
enum value was switched on which would have caused a fatal error at
runtime.
This patch replaces uses of `latest_status` with `state` which does
contain the information we care about. We also adjust the error
logging so we log the value that lead to the error, not some other
value.
Diffs (updated)
-----
src/slave/slave.cpp 858b78620e1ef33f3587d0bd95a684917aaf5bbb
Diff: https://reviews.apache.org/r/69157/diff/4/
Changes: https://reviews.apache.org/r/69157/diff/3-4/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
