> On Nov. 20, 2018, 8:05 p.m., Chun-Hung Hsiao wrote: > > Could you update the commit message accordingly?
Do you have a suggestion? - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69157/#review210737 ----------------------------------------------------------- On Nov. 27, 2018, 6:59 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69157/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2018, 6:59 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Bugs: MESOS-8403 > https://issues.apache.org/jira/browse/MESOS-8403 > > > Repository: mesos > > > Description > ------- > > The handling of offer operation updates introduced in `c946615ec6d` > made use of an update's `latest_status` without making sure that any > value was set. This could lead to situation where an uninitialized > enum value was switched on which would have caused a fatal error at > runtime. > > This patch replaces uses of `latest_status` with `state` which does > contain the information we care about. We also adjust the error > logging so we log the value that lead to the error, not some other > value. > > > Diffs > ----- > > src/slave/slave.cpp 858b78620e1ef33f3587d0bd95a684917aaf5bbb > > > Diff: https://reviews.apache.org/r/69157/diff/5/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
