----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69071/#review210959 -----------------------------------------------------------
Ship it! LGTM, pending the other parts of the chain. - Joseph Wu On Nov. 21, 2018, 5:19 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69071/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2018, 5:19 p.m.) > > > Review request for mesos, Alexander Rukletsov and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Previously, the members of `ReadOnlyHandler` would take a full `Request` as > parameter, making it hard for clients to reason about which parts of the > request are used internally, and even harder to guarantee that behaviour into > the future. > > This commit changes the interface so only the query parameters get passed. > > > Diffs > ----- > > src/master/http.cpp 68ee2a6dcffbc772afec6e797b1af8da48f61937 > src/master/master.hpp 3b3c1a4e61de9503c8d038dd3bee623ded5914c9 > src/master/readonly_handler.cpp 8895374499dc6baa2c4d8a8dd86fddac4e39be29 > > > Diff: https://reviews.apache.org/r/69071/diff/2/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
