----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/#review211264 -----------------------------------------------------------
include/mesos/slave/containerizer.proto Lines 200-215 (patched) <https://reviews.apache.org/r/68017/#comment296202> I saw you remove all `SCMP_` prefix and implemented a hashmap converter in the next patch. You do this for `AUDIT_` architecture on pupose? include/mesos/slave/containerizer.proto Lines 257-259 (patched) <https://reviews.apache.org/r/68017/#comment296207> Do we want `Arches`? or we could leave a TODO here. I am think about whether we should have a linux specific proto enum for Architecture like S390X etc. include/mesos/slave/containerizer.proto Lines 262 (patched) <https://reviews.apache.org/r/68017/#comment296206> Is an `action` repeated in this case? include/mesos/slave/containerizer.proto Lines 263-264 (patched) <https://reviews.apache.org/r/68017/#comment296205> Even we do not use `comments` now, but it may be used in the future. I would suggest to add it now with no-ops, or add a TODO include/mesos/slave/containerizer.proto Lines 269 (patched) <https://reviews.apache.org/r/68017/#comment296203> How do we add repeated `subArchitectures` under the current `Architecture` in the future? - Gilbert Song On Nov. 8, 2018, 7:24 a.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68017/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2018, 7:24 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang. > > > Bugs: MESOS-9033 > https://issues.apache.org/jira/browse/MESOS-9033 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 06a901d26693757edc653cd833d55aa42e4ff2c6 > include/mesos/slave/containerizer.proto > 5b4dcdda0f55ea3355c78d1447c7be9ca54d9dc9 > include/mesos/v1/mesos.proto 75cdb2889b2b645e23d9f5ab263ee63bf62b4221 > > > Diff: https://reviews.apache.org/r/68017/diff/10/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
