----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/#review211492 -----------------------------------------------------------
include/mesos/mesos.proto Lines 3089 (patched) <https://reviews.apache.org/r/68017/#comment296692> Can we mention the name of the flag here? include/mesos/slave/containerizer.proto Lines 197 (patched) <https://reviews.apache.org/r/68017/#comment296698> Can you please elaborate a bit why our internal json format is incompatible with Docker Seccomp profile format? include/mesos/slave/containerizer.proto Lines 250-254 (patched) <https://reviews.apache.org/r/68017/#comment296697> If it is `Some` comparison operators accept two values, should this field be optional? include/mesos/slave/containerizer.proto Lines 256-257 (patched) <https://reviews.apache.org/r/68017/#comment296694> Can you please add a comment for this message? include/mesos/slave/containerizer.proto Lines 258 (patched) <https://reviews.apache.org/r/68017/#comment296695> Should it be `repeated CapabilityInfo.Capability caps`? - Qian Zhang On Nov. 8, 2018, 11:24 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68017/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2018, 11:24 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang. > > > Bugs: MESOS-9033 > https://issues.apache.org/jira/browse/MESOS-9033 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 06a901d26693757edc653cd833d55aa42e4ff2c6 > include/mesos/slave/containerizer.proto > 5b4dcdda0f55ea3355c78d1447c7be9ca54d9dc9 > include/mesos/v1/mesos.proto 75cdb2889b2b645e23d9f5ab263ee63bf62b4221 > > > Diff: https://reviews.apache.org/r/68017/diff/10/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
