----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69590/#review211418 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/cni/paths.hpp Line 49 (original), 52 (patched) <https://reviews.apache.org/r/69590/#comment296507> One more newline. src/slave/containerizer/mesos/isolators/network/cni/paths.hpp Line 50 (original), 54 (patched) <https://reviews.apache.org/r/69590/#comment296508> Ditto. src/slave/containerizer/mesos/isolators/network/cni/paths.cpp Lines 37-38 (patched) <https://reviews.apache.org/r/69590/#comment296505> A newline between. src/slave/containerizer/mesos/isolators/network/cni/paths.cpp Lines 40 (patched) <https://reviews.apache.org/r/69590/#comment296506> One more newline. src/slave/flags.hpp Lines 165 (patched) <https://reviews.apache.org/r/69590/#comment296504> We need to update `agent.md` by adding this new flag into it, and also need to update `cni.md` to describe this new flag. src/slave/flags.cpp Lines 1191 (patched) <https://reviews.apache.org/r/69590/#comment296503> Should the default value be `false` for backward compatibility? - Qian Zhang On Dec. 19, 2018, 10:03 a.m., Deepak Goel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69590/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2018, 10:03 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Sergey > Urbanovich. > > > Bugs: MESOS-9492 > https://issues.apache.org/jira/browse/MESOS-9492 > > > Repository: mesos > > > Description > ------- > > This patch moves the CNI root directory to mesos working directory > so that the network related information persist across reboot which > will allow cni isolator to do proper cleanup post reboot > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > f19edce0671686bc2dccf5dc6d3abc40b925852e > src/slave/containerizer/mesos/isolators/network/cni/paths.hpp > 3b06fb101d03b32a3a148e2b79502413a7268d1e > src/slave/containerizer/mesos/isolators/network/cni/paths.cpp > c1cb4f7d667159abbf87219cde30528a4a7b5283 > src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8 > src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686 > src/tests/containerizer/cni_isolator_tests.cpp > 5473737cdc71a3179c22be0d4db2060a6ef53d24 > > > Diff: https://reviews.apache.org/r/69590/diff/2/ > > > Testing > ------- > > > Thanks, > > Deepak Goel > >
