> On Dec. 19, 2018, 2:51 a.m., Qian Zhang wrote: > > src/slave/flags.cpp > > Lines 1191 (patched) > > <https://reviews.apache.org/r/69590/diff/1/?file=2114817#file2114817line1191> > > > > Should the default value be `false` for backward compatibility?
Hmm yeah maybe it's better if we make it default to `false` for now, and ask around the community to make the discussion transparent for a plan to enable it by default if needed. Also it is worth mentioning this new flag in `docs/configuration/agent.md` and `docs/upgrades.md`. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69590/#review211418 ----------------------------------------------------------- On Dec. 19, 2018, 3:25 a.m., Deepak Goel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69590/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2018, 3:25 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Sergey > Urbanovich. > > > Bugs: MESOS-9492 > https://issues.apache.org/jira/browse/MESOS-9492 > > > Repository: mesos > > > Description > ------- > > This patch moves the CNI root directory to mesos working directory > so that the network related information persist across reboot which > will allow cni isolator to do proper cleanup post reboot > > > Diffs > ----- > > docs/cni.md 4a0e0bf57c6ff8d2bcc9fdf30d20672324da224c > docs/configuration/agent.md 7a8df6852dc2af174a6c5a552dca88fa1b1c29f3 > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > f19edce0671686bc2dccf5dc6d3abc40b925852e > src/slave/containerizer/mesos/isolators/network/cni/paths.hpp > 3b06fb101d03b32a3a148e2b79502413a7268d1e > src/slave/containerizer/mesos/isolators/network/cni/paths.cpp > c1cb4f7d667159abbf87219cde30528a4a7b5283 > src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8 > src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686 > src/tests/containerizer/cni_isolator_tests.cpp > 5473737cdc71a3179c22be0d4db2060a6ef53d24 > > > Diff: https://reviews.apache.org/r/69590/diff/3/ > > > Testing > ------- > > > Thanks, > > Deepak Goel > >
