----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69712/#review211871 -----------------------------------------------------------
src/tests/containerizer/cni_isolator_tests.cpp Lines 2612-2613 (patched) <https://reviews.apache.org/r/69712/#comment297452> `%s` is the total size, should we check the device ID instead? src/tests/containerizer/cni_isolator_tests.cpp Lines 2621-2622 (patched) <https://reviews.apache.org/r/69712/#comment297451> Why do we need these? src/tests/containerizer/cni_isolator_tests.cpp Lines 2722 (patched) <https://reviews.apache.org/r/69712/#comment297453> s/1u/1/ since what `containers_size` returns is `int`. src/tests/containerizer/cni_isolator_tests.cpp Lines 2763-2764 (patched) <https://reviews.apache.org/r/69712/#comment297454> This comment seems not correct. - Qian Zhang On Jan. 11, 2019, 1:13 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69712/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2019, 1:13 p.m.) > > > Review request for mesos, Deepak Goel, Gilbert Song, James Peach, and Qian > Zhang. > > > Bugs: MESOS-9518 > https://issues.apache.org/jira/browse/MESOS-9518 > > > Repository: mesos > > > Description > ------- > > This test verifies that CNI DEL is properly called even after the agent > host is rebooted, assuming `--network_cni_root_dir_persist` flag is set > to true. > > > Diffs > ----- > > src/tests/containerizer/cni_isolator_tests.cpp > eb20e637ecbe1b39e2dbb274c5198828f2fdf62f > > > Diff: https://reviews.apache.org/r/69712/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
