> On Jan. 11, 2019, 9:38 a.m., Qian Zhang wrote: > > src/tests/containerizer/cni_isolator_tests.cpp > > Lines 2612-2613 (patched) > > <https://reviews.apache.org/r/69712/diff/1/?file=2119174#file2119174line2612> > > > > `%s` is the total size, should we check the device ID instead?
err, this is unforntate, this %s is used to print %d. But I figured out a better way to use `%%d` > On Jan. 11, 2019, 9:38 a.m., Qian Zhang wrote: > > src/tests/containerizer/cni_isolator_tests.cpp > > Lines 2763-2764 (patched) > > <https://reviews.apache.org/r/69712/diff/1/?file=2119174#file2119174line2763> > > > > This comment seems not correct. GOod catch! copy paste error :facepalm - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69712/#review211871 ----------------------------------------------------------- On Jan. 11, 2019, 5:13 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69712/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2019, 5:13 a.m.) > > > Review request for mesos, Deepak Goel, Gilbert Song, James Peach, and Qian > Zhang. > > > Bugs: MESOS-9518 > https://issues.apache.org/jira/browse/MESOS-9518 > > > Repository: mesos > > > Description > ------- > > This test verifies that CNI DEL is properly called even after the agent > host is rebooted, assuming `--network_cni_root_dir_persist` flag is set > to true. > > > Diffs > ----- > > src/tests/containerizer/cni_isolator_tests.cpp > eb20e637ecbe1b39e2dbb274c5198828f2fdf62f > > > Diff: https://reviews.apache.org/r/69712/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
