> On Jan. 14, 2019, 11:55 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 1004-1005 (patched) > > <https://reviews.apache.org/r/69719/diff/1/?file=2119190#file2119190line1004> > > > > How about the following, to make it consistent with, e.g., > > `master/messages_register_framework`, and also make it less confusing w/ > > `resource_provider_manager/subscribed`? > > ``` > > messages_subscribe("resource_provider_manager/messages_subscribe"), > > messages_disconnect("resource_provider_manager/messages_disconnect") > > ``` > > Benjamin Bannier wrote: > These are not really counters for messages as disconnections have no > relation to messages the RP manager receives, and the subscriptions counter > is supposed to count successfull connections (not just all subscription > attempts (this allows correlating subscription and disconnection counters). > What do you think about naming them e.g., > `resource_provider_manager/events/[subscribe|disconnect]`? We could introduce > a separate counter for subscription messages later.
Hmm I was actually thinking about the number of `ResourceProviderMessage` enqueued by the RP manager (and received by the agent actor). But yeah the names I suggested here are confusing, as you pointed out that one might think they're messages received by the RP manager. (I also confused myself with `master/messages_register_framework`.) Not sure if `events` would make it better. I'm fine with keeping it as-is or go with `events` now. Dropping. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69719/#review211971 ----------------------------------------------------------- On Jan. 15, 2019, 9:27 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69719/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2019, 9:27 a.m.) > > > Review request for mesos, Chun-Hung Hsiao and James DeFelice. > > > Bugs: MESOS-9223 > https://issues.apache.org/jira/browse/MESOS-9223 > > > Repository: mesos > > > Description > ------- > > This patch adds monotonically increasing counters for subscriptions and > disconnections of resource providers with the resource provider manager > (`resource_provider_manager/subscriptions` and > `resource_provider_manager/disconnections`, respectively). While the > existing gauge `resource_provider_manager/subscribed` exposed the > current state, these added counters can be used to monitor resource > provider state for unexpected events. > > > Diffs > ----- > > src/resource_provider/manager.cpp 65852c629393f32fd582bfcff86d7ce14e5386ac > src/tests/resource_provider_manager_tests.cpp > 455ce7d2c71f2815430b69a5475b2ccc343cd9af > > > Diff: https://reviews.apache.org/r/69719/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
