----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69719/#review211878 -----------------------------------------------------------
PASS: Mesos patch 69719 was successfully built and tested. Reviews applied: `['69606', '69719']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2758/mesos-review-69719 - Mesos Reviewbot Windows On Jan. 11, 2019, 10:02 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69719/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2019, 10:02 a.m.) > > > Review request for mesos, Chun-Hung Hsiao and James DeFelice. > > > Bugs: MESOS-9223 > https://issues.apache.org/jira/browse/MESOS-9223 > > > Repository: mesos > > > Description > ------- > > This patch adds monotonically increasing counters for subscriptions and > disconnections of resource providers with the resource provider manager > (`resource_provider_manager/subscriptions` and > `resource_provider_manager/disconnections`, respectively). While the > existing gauge `resource_provider_manager/subscribed` exposed the > current state, these added counters can be used to monitor resource > provider state for unexpected events. > > > Diffs > ----- > > src/resource_provider/manager.cpp 65852c629393f32fd582bfcff86d7ce14e5386ac > src/tests/resource_provider_manager_tests.cpp > 20cfb340bf634354865d79c92ee70cddca08f28a > > > Diff: https://reviews.apache.org/r/69719/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
