-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69866/
-----------------------------------------------------------
(Updated Jan. 30, 2019, 11:41 p.m.)
Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.
Changes
-------
Made the definition of the `v1::CREATE_DISK` helper more consistent with other
helpers.
Bugs: MESOS-9537
https://issues.apache.org/jira/browse/MESOS-9537
Repository: mesos
Description
-------
This patch updates `StorageLocalResourceProviderTest.ProfileDisappeared`
to use the v1 scheduler API to request operation feedbacks, so
MESOS-9537 would be triggered when an outstanding `UPDATE_STATE` call
from the resource provider races with an offer operation.
Diffs (updated)
-----
src/tests/mesos.hpp c2a5e5531de7498241e537ef1699e1a5e669b550
src/tests/storage_local_resource_provider_tests.cpp
e8ed20f818ed7f1a3ce15758ea3c366520443377
Diff: https://reviews.apache.org/r/69866/diff/2/
Changes: https://reviews.apache.org/r/69866/diff/1-2/
Testing
-------
`make check`
Ran the test ~1000 times.
This test will fail without r/69858:
```
E0130 22:48:02.790385 24040 provider.cpp:2903] Failed to update status of
operation (uuid: 2bf6813c-bde9-4c0e-8831-a779f5dc50ac): Mismatched framework ID
for operation status update OPERATION_DROPPED (Status UUID:
8a625c40-96e8-46e2-8050-69843032969a) for operation UUID
2bf6813c-bde9-4c0e-8831-a779f5dc50ac on agent
bfa6e505-54b7-4bb8-a8aa-99fb12291fb1-S0 (expected
bfa6e505-54b7-4bb8-a8aa-99fb12291fb1-0000 got no framework ID)
I0130 22:48:02.791590 24042 manager.cpp:163] Terminating resource provider
765391c2-9485-4614-a6e5-45e67ef7a92c
...
../../src/tests/storage_local_resource_provider_tests.cpp:1387: Failure
Expected: v1::OPERATION_FINISHED
Which is: OPERATION_FINISHED
To be equal to: update->status().state()
Which is: OPERATION_ERROR
../../src/tests/storage_local_resource_provider_tests.cpp:1393: Failure
Failed to wait 15secs for offers
...
../../src/tests/storage_local_resource_provider_tests.cpp:1361: Failure
Actual function call count doesn't match EXPECT_CALL(*scheduler, offers(_,
v1::scheduler::OffersHaveAnyResource( std::bind(isStoragePool, lambda::_1,
"test2"))))...
Expected: to be called once
Actual: never called - unsatisfied and active
```
Thanks,
Chun-Hung Hsiao
