----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70080/#review213335 -----------------------------------------------------------
Fix it, then Ship it! src/common/resources_utils.cpp Line 337 (original), 337 (patched) <https://reviews.apache.org/r/70080/#comment299290> Let's break before ` {`. - Benjamin Bannier On March 1, 2019, 6:47 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70080/ > ----------------------------------------------------------- > > (Updated March 1, 2019, 6:47 a.m.) > > > Review request for mesos, Benjamin Bannier and Jan Schlicht. > > > Bugs: MESOS-9607 > https://issues.apache.org/jira/browse/MESOS-9607 > > > Repository: mesos > > > Description > ------- > > Changed the `getResourceProviderId` helper to take a `Resources`. > > > Diffs > ----- > > src/common/resources_utils.hpp 74cf747eb9f6b4f3642bdc214c59d704c993e8b0 > src/common/resources_utils.cpp 3b4fcd6761e40dccf8c64a71ad4adda603487d1a > src/master/master.cpp 015da54583448a8d102d8e401e48bd228baf6dd6 > > > Diff: https://reviews.apache.org/r/70080/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
