----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70084/#review213419 -----------------------------------------------------------
Patch looks great! Reviews applied: [70080, 70081, 70084] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 2, 2019, 1:04 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70084/ > ----------------------------------------------------------- > > (Updated March 2, 2019, 1:04 a.m.) > > > Review request for mesos, Gilbert Song, Greg Mann, Jie Yu, Meng Zhu, and > Vinod Kone. > > > Bugs: MESOS-8467 > https://issues.apache.org/jira/browse/MESOS-8467 > > > Repository: mesos > > > Description > ------- > > When launching executors and tasks, there is no guarantee that the > executors still remain after `Slave::publishResources` is returned. If > not, the executor struct should not be dereferenced and the executor > containers should not be launched at all. > > NOTE: The patch makes `Slave::launchExecutor` called asynchronously even > if there is no secret generator. However this should not affect the > correctness of executor launching. > > > Diffs > ----- > > src/slave/slave.hpp 7ad495504e4ff144ac31812fbd4a3a1f4da86f02 > src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79 > > > Diff: https://reviews.apache.org/r/70084/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
