-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70084/
-----------------------------------------------------------
(Updated April 10, 2019, 6:26 p.m.)
Review request for mesos, Gilbert Song, Greg Mann, Jie Yu, Meng Zhu, and Vinod
Kone.
Changes
-------
Addressed Meng's comments.
Bugs: MESOS-8467
https://issues.apache.org/jira/browse/MESOS-8467
Repository: mesos
Description
-------
When launching executors and tasks, there is no guarantee that the
executors still remain after `Slave::publishResources` is returned. If
not, the executor struct should not be dereferenced and the executor
containers should not be launched at all.
NOTE: The patch makes `Slave::launchExecutor` called asynchronously even
if there is no secret generator. However this should not affect the
correctness of executor launching.
Diffs (updated)
-----
src/slave/slave.hpp 2bffdc4b1e282d3c6dae2dcf23584a8a4550bf94
src/slave/slave.cpp 794a9c986b266b4916f6fbada670142798245bd1
Diff: https://reviews.apache.org/r/70084/diff/2/
Changes: https://reviews.apache.org/r/70084/diff/1-2/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
