----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70169/#review213572 -----------------------------------------------------------
Patch looks great! Reviews applied: [70168, 70169] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 8, 2019, 7:29 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70169/ > ----------------------------------------------------------- > > (Updated March 8, 2019, 7:29 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-9632 > https://issues.apache.org/jira/browse/MESOS-9632 > > > Repository: mesos > > > Description > ------- > > Refactored SLRP to use `ServiceManager`. > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp > fea623c292158deb1b4b4b9ab1ac208031471519 > src/resource_provider/storage/provider_process.hpp > a5536b3d735e01eb1c4dc52d0602d973155f3c93 > > > Diff: https://reviews.apache.org/r/70169/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >