----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70116/#review213734 -----------------------------------------------------------
src/master/metrics.hpp Lines 82-84 (patched) <https://reviews.apache.org/r/70116/#comment299715> Hmm am I missing something, or are there no per-framework metrics added? I'm fine with not adding them, but this comment seems to be incorrect? - Greg Mann On March 11, 2019, 7:14 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70116/ > ----------------------------------------------------------- > > (Updated March 11, 2019, 7:14 p.m.) > > > Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu. > > > Bugs: MESOS-8241 > https://issues.apache.org/jira/browse/MESOS-8241 > > > Repository: mesos > > > Description > ------- > > This commit adds additional metrics counting the > number of operations in each state. > > Unit tests are added in the subsequent commit. > > > Diffs > ----- > > src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce > src/master/metrics.hpp 4495e65b6bb11f7236335a702c4f61e7c3f9b0aa > src/master/metrics.cpp 4dd73fb18a06ce8f75c4c1435dba84ade123bee9 > > > Diff: https://reviews.apache.org/r/70116/diff/4/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
