> On March 15, 2019, 12:03 a.m., Greg Mann wrote: > > src/master/metrics.hpp > > Lines 82-84 (patched) > > <https://reviews.apache.org/r/70116/diff/4/?file=2130966#file2130966line82> > > > > Hmm am I missing something, or are there no per-framework metrics > > added? I'm fine with not adding them, but this comment seems to be > > incorrect? > > Benno Evers wrote: > They're not added in this review because they already exist :) See line > 816-836 inside `FrameworkMetrics::FrameworkMetrics()`. > > Greg Mann wrote: > Those metrics are slightly different - they provide counters for the > offer operations submitted by a particular framework, but don't track the > operation states. It might be worth mentioning in this comment that offer > operation counts are tracked on a per-framework basis.
Oh, right. Updated the comment. - Benno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70116/#review213734 ----------------------------------------------------------- On March 27, 2019, 4:39 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70116/ > ----------------------------------------------------------- > > (Updated March 27, 2019, 4:39 p.m.) > > > Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu. > > > Bugs: MESOS-8241 > https://issues.apache.org/jira/browse/MESOS-8241 > > > Repository: mesos > > > Description > ------- > > This commit adds additional metrics counting the > number of operations in each state. > > Unit tests are added in the subsequent commit. > > > Diffs > ----- > > docs/monitoring.md 54b872f579dbc68ca5f67f4cc1ba34065a09aee2 > src/master/master.cpp 9c4a9e83da94535873d72c902835f229c4f96320 > src/master/metrics.hpp 4495e65b6bb11f7236335a702c4f61e7c3f9b0aa > src/master/metrics.cpp 4dd73fb18a06ce8f75c4c1435dba84ade123bee9 > > > Diff: https://reviews.apache.org/r/70116/diff/6/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
