----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70168/#review213772 -----------------------------------------------------------
I could only review small parts of this patch and didn't dig deep into the functionality. src/csi/metrics.cpp Lines 43-44 (patched) <https://reviews.apache.org/r/70168/#comment299763> While I like the idea of having a compile-time check, this feels like obfuscating and complicating the code. We should keep it simple. src/csi/metrics.cpp Lines 46-81 (patched) <https://reviews.apache.org/r/70168/#comment299760> This will only push `csi::v0::GET_PLUGIN_INFO` into `rpcs`. src/csi/service_manager.hpp Lines 55 (patched) <https://reviews.apache.org/r/70168/#comment299759> Remove the `explicit`. src/csi/service_manager.cpp Lines 96 (patched) <https://reviews.apache.org/r/70168/#comment299764> Remove the `explicit`. - Jan Schlicht On March 12, 2019, 7:59 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70168/ > ----------------------------------------------------------- > > (Updated March 12, 2019, 7:59 p.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-9632 > https://issues.apache.org/jira/browse/MESOS-9632 > > > Repository: mesos > > > Description > ------- > > The `ServiceManager` is agnostic to CSI versions, so can be used to > manage plugin containers for both CSI v0 and v1 plugins. Most of its > logic are adapted from the SLRP code. > > We also separate the CSI plugin metrics from SLRP metrics object so the > metrics can be accessed by `ServiceManager`. However, we do not make > `ServiceManager` own the CSI plugin metrics object because eventually we > would like to decouple metrics lifecycles from SLRP lifecycles. > > > Diffs > ----- > > src/CMakeLists.txt 3397c3b1d4e8a7900b2e5f870679cc7aa30b4be2 > src/Makefile.am d451d7cabe3bf5d4f5039cfac5de1b03ef891d07 > src/csi/metrics.hpp PRE-CREATION > src/csi/metrics.cpp PRE-CREATION > src/csi/service_manager.hpp PRE-CREATION > src/csi/service_manager.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/70168/diff/6/ > > > Testing > ------- > > Testing done later in chain. > > > Thanks, > > Chun-Hung Hsiao > >