----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70381/#review214342 -----------------------------------------------------------
Patch looks great! Reviews applied: [70381] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 3, 2019, 6:19 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70381/ > ----------------------------------------------------------- > > (Updated April 3, 2019, 6:19 p.m.) > > > Review request for mesos, Benjamin Bannier and Meng Zhu. > > > Bugs: MESOS-9696 > https://issues.apache.org/jira/browse/MESOS-9696 > > > Repository: mesos > > > Description > ------- > > In this test it was possible for the agent to retry registration > either from the initial registration attempt's retry backoff loop, > or from the master pinging it with the disconnected bit set. Pausing > the clock prevents these issues. > > > Diffs > ----- > > src/tests/master_quota_tests.cpp 0337f104fde398c9bc0878e49f90f16c785342f6 > > > Diff: https://reviews.apache.org/r/70381/diff/1/ > > > Testing > ------- > > Ran in repetition. > > > Thanks, > > Benjamin Mahler > >