----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69955/#review214690 -----------------------------------------------------------
Fix it, then Ship it! src/tests/storage_local_resource_provider_tests.cpp Lines 454 (patched) <https://reviews.apache.org/r/69955/#comment300898> Let's add a log message here. src/tests/storage_local_resource_provider_tests.cpp Lines 3328 (patched) <https://reviews.apache.org/r/69955/#comment300900> If we need to await offers, lets also check their contents. It seems checking the operation status would already be enough. src/tests/storage_local_resource_provider_tests.cpp Lines 3542 (patched) <https://reviews.apache.org/r/69955/#comment300901> Ditto. src/tests/storage_local_resource_provider_tests.cpp Lines 3792 (patched) <https://reviews.apache.org/r/69955/#comment300902> Ditto. - Benjamin Bannier On April 13, 2019, 12:02 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69955/ > ----------------------------------------------------------- > > (Updated April 13, 2019, 12:02 a.m.) > > > Review request for mesos and Benjamin Bannier. > > > Bugs: MESOS-9565 > https://issues.apache.org/jira/browse/MESOS-9565 > > > Repository: mesos > > > Description > ------- > > This patch adds 3 unit tests: `DestroyUnpublishedPersistentVolume`, > `DestroyUnpublishedPersistentVolumeWithRecovery`, and > `DestroyUnpublishedPersistentVolumeWithReboot` to test that the SLRP is > resilient to misbehaved CSI plugins that fail to publish volumes. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > 8bf4d2331b59770a7b7f3768499047bec2d67677 > > > Diff: https://reviews.apache.org/r/69955/diff/3/ > > > Testing > ------- > > make check > > All tests passed 400 iterations (200 per parameter value) under stress. > > > Thanks, > > Chun-Hung Hsiao > >
