-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70577/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Greg Mann, and Vinod Kone.
Bugs: MESOS-9750
https://issues.apache.org/jira/browse/MESOS-9750
Repository: mesos
Description
-------
It is possible for a completed executor to have a non-terminal task
(based on last status update). For example, during graceful shutdown
of an agent, graceful shutdown of an executor will race with the
agent's shutdown grace period. If the executor does not send a
TASK_KILLED in time, the agent will still mark the executor as complete
and kill it.
After agent recovery, these completed executors will show up in an
agent's /state and GET_STATE responses. In GET_STATE however, any
non-terminal tasks will appear under `launched_tasks`. This may
provide misleading information about the total number of tasks running.
This commit adds extra logic to place these non-terminal tasks under
the `terminated_tasks` category, and adds a regression test.
Diffs
-----
src/slave/http.cpp 2c4e792d16ad4fd3303760a9db3cba4269152e7d
src/tests/api_tests.cpp bc19d7e9661f091aebf3072967548c7c3196239d
Diff: https://reviews.apache.org/r/70577/diff/1/
Testing
-------
```
make
src/mesos-tests --gtest_filter="*GetStateWithNonTerminalCompletedTask*"
--verbose
```
TODO: more testing
Thanks,
Joseph Wu
