----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70581/#review215004 -----------------------------------------------------------
The new flag should also be documented in the [upgrade](https://github.com/apache/mesos/blob/master/docs/upgrades.md) doc. You'll need to add a new 1.9.x section. - James Peach On May 2, 2019, 6:06 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70581/ > ----------------------------------------------------------- > > (Updated May 2, 2019, 6:06 p.m.) > > > Review request for mesos, Gilbert Song and James Peach. > > > Bugs: MESOS-9760 > https://issues.apache.org/jira/browse/MESOS-9760 > > > Repository: mesos > > > Description > ------- > > Docker runtime isolator propagates manifest configuration metadata. > This is not always desirable, e.g. a customer may want to ignore the > defined WORKDIR/ENV defined in the manifest. > > https://issues.apache.org/jira/browse/MESOS-9760 > > > Diffs > ----- > > docs/configuration/agent.md 04d7114e92c189afd04a8889b3ab853ade9deec6 > src/slave/containerizer/mesos/provisioner/store.cpp > 11fce0eb47e9e6dfce6289afe04a1d58a0c4461a > src/slave/flags.hpp 09921cb6172202b5c1d2f8d03f9ccaeb3d0e8c94 > src/slave/flags.cpp 49a350f9e13409493fa9612c53d9d58b62122371 > > > Diff: https://reviews.apache.org/r/70581/diff/1/ > > > Testing > ------- > > > Thanks, > > Jacob Janco > >
