----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70581/#review215237 -----------------------------------------------------------
Patch looks great! Reviews applied: [70581] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 13, 2019, 8:13 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70581/ > ----------------------------------------------------------- > > (Updated May 13, 2019, 8:13 p.m.) > > > Review request for mesos, Gilbert Song and James Peach. > > > Bugs: MESOS-9760 > https://issues.apache.org/jira/browse/MESOS-9760 > > > Repository: mesos > > > Description > ------- > > Docker runtime isolator propagates manifest configuration metadata. > This is not always desirable, e.g. a customer may want to ignore the > defined WORKDIR/ENV defined in the manifest. > > https://issues.apache.org/jira/browse/MESOS-9760 > > > Diffs > ----- > > docs/configuration/agent.md 04d7114e92c189afd04a8889b3ab853ade9deec6 > docs/upgrades.md ece8462b9950626166c832d3b554ad51f68f42e1 > src/slave/containerizer/mesos/containerizer.cpp > c4a6827c5574586475152b1dc31572d6e1821a82 > src/slave/flags.hpp 09921cb6172202b5c1d2f8d03f9ccaeb3d0e8c94 > src/slave/flags.cpp 49a350f9e13409493fa9612c53d9d58b62122371 > src/tests/containerizer/provisioner_docker_tests.cpp > 1c5d72091d570001ad543e342ab0b9128ffc01ae > > > Diff: https://reviews.apache.org/r/70581/diff/3/ > > > Testing > ------- > > > Thanks, > > Jacob Janco > >
