----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70534/#review215042 -----------------------------------------------------------
Patch looks great! Reviews applied: [70583, 70531, 70530, 70532, 70533, 70534] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 2, 2019, 4:06 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70534/ > ----------------------------------------------------------- > > (Updated May 2, 2019, 4:06 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7258 > https://issues.apache.org/jira/browse/MESOS-7258 > > > Repository: mesos > > > Description > ------- > > This patch adds tests for the UPDATE_FRAMEWORK call. > > The reason behind implementing the MasterAPISubscriber class with mock > methods is the need to wait for interesting API events while skipping > uninteresting ones. > This is needed to properly test the FRAMEWORK_UPDATED event sent by the > master (for that I need to wait for AGENT_ADDED and FRAMEWORK_UPDATED, and to > skip everything else). > > I'm in doubts about the proper location for the MasterAPISubscriber. On one > hand, it is used only by these tests and the implementation is by no means > complete; on the other hand, this might be useful in other tests of the > master API behaviour. > Probably, turning the MasterAPISubscriber into a general-purpose mock (and > moving it into another file at that point) should be a separate task. > > > Diffs > ----- > > src/Makefile.am 5f97523fbe2d80733fbdcc7706f2761f5a071f9f > src/tests/CMakeLists.txt e6b1d8a097246f0921467d7f778034d6754fcff6 > src/tests/update_framework_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/70534/diff/3/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
