----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70549/#review215160 -----------------------------------------------------------
include/mesos/authorizer/authorizer.proto Lines 138-140 (original), 139-144 (patched) <https://reviews.apache.org/r/70549/#comment301682> If my understanding is correct, both `UPDATE_QUOTA` and `UPDATE_QUOTA_CONFIG` are per role but use different objects in payload. Can we convert `QuotaConfig` to `QuotaInfo` for the purpose of authorization and spare extra action altogether? I see that authorization implementation is identical and does not rely on differences between `QuotaConfig` and `QuotaInfo`. include/mesos/authorizer/authorizer.proto Lines 143 (patched) <https://reviews.apache.org/r/70549/#comment301683> If you do plan to keep this action, the naming convention in this file suggests: `UPDATE_QUOTA_WITH_CONFIG` or `UPDATE_QUOTA_WITH_QUOTA_CONFIG`. - Alexander Rukletsov On May 6, 2019, 11 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70549/ > ----------------------------------------------------------- > > (Updated May 6, 2019, 11 p.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Bugs: MESOS-9640 > https://issues.apache.org/jira/browse/MESOS-9640 > > > Repository: mesos > > > Description > ------- > > A new authorizable action `update_quota_configs` is added. > This disambiguates with the old action `update_quota` > which are used for the old `SetQuota` and > `RemoveQuota` calls. `update_quota` action requires > `QuotaInfo` as the object while the new `UpdatedQuota` call > uses `QuotaConfig`. To keep it compatible with any external > authorization modules, a new action `update_quota_config` > is introduced. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.proto > e2740c402732bb37db991ec92b9301e58b33215b > src/master/master.hpp 7d9732f1e432f6f0290d234242864cbdbf381fa8 > src/master/quota_handler.cpp 5d449e6f027a69ccaa0ac3473ea4cf57441601f3 > > > Diff: https://reviews.apache.org/r/70549/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
