> On Июнь 7, 2019, 6:55 п.п., Benjamin Bannier wrote: > > src/slave/containerizer/mesos/launch.cpp > > Line 508 (original), 509 (patched) > > <https://reviews.apache.org/r/70811/diff/1/?file=2148200#file2148200line510> > > > > For non-`__linux-_` cases this silently drops any configuration. Why > > wouldn't we return an error in that case instead?
This cpp-module has inconsistencies with handling of Linux/non-Linux cases. For example, `prepareMounts` and `maskPath` are simply no-ops on non-Linux platforms. This patch fixes compilation error. Fixing the whole inconsistency issue in a single place is not a goal here. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70811/#review215759 ----------------------------------------------------------- On Июнь 7, 2019, 5:21 п.п., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70811/ > ----------------------------------------------------------- > > (Updated Июнь 7, 2019, 5:21 п.п.) > > > Review request for mesos, Benjamin Bannier, Gilbert Song, James Peach, and > Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > This patch adds missing switch case to fix compilation error introduced > in `bc5a57122635`. > > > Diffs > ----- > > src/slave/containerizer/mesos/launch.cpp > a69a68823842171bb15ddf34a504e5ce4af232b0 > > > Diff: https://reviews.apache.org/r/70811/diff/1/ > > > Testing > ------- > > internal CI > > > Thanks, > > Andrei Budnik > >
