> On June 19, 2019, 10:56 p.m., Benjamin Mahler wrote: > > Very nice, thanks for doing this! > > > > Is this committable without the previous changes in this chain? If not, can > > you make it committable so we don't have to wait for > > https://reviews.apache.org/r/70894/?
Yes, it is committable. Doesn't depend on any previous patches. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70896/#review215981 ----------------------------------------------------------- On June 19, 2019, 6:27 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70896/ > ----------------------------------------------------------- > > (Updated June 19, 2019, 6:27 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9793 > https://issues.apache.org/jira/browse/MESOS-9793 > > > Repository: mesos > > > Description > ------- > > This patch replaces several pieces of code which build std::vector<T> > from a Java collection with a single function template. > This is a prerequisite for adding one more collection argument to the > bindings. > > > Diffs > ----- > > src/java/jni/construct.hpp 3d3f6c7eeda9136b9231b079ac3743c5cc634609 > src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp > b47976376ce49b518d97a702a794b704cb79dcdd > > > Diff: https://reviews.apache.org/r/70896/diff/1/ > > > Testing > ------- > > `./bin/mesos-tests.sh --gtest_filter="*Java*" --gtest_break_on_failure > --gtest_repeat=10` > > > Thanks, > > Andrei Sekretenko > >
