> On June 27, 2019, 5:29 p.m., Benjamin Bannier wrote: > > src/tests/slave_tests.cpp > > Lines 12362-12369 (patched) > > <https://reviews.apache.org/r/70960/diff/2/?file=2152614#file2152614line12362> > > > > This block doesn't work reliably. On when running on Linux I seem to > > get a resend `lostUpdate` with decent reliability while on macos > > `lostUpdate` is immediately followed by `killedUpdate1`. > > > > Any idea what I am missing?
The test was rewritten to not trigger resent status updates anymore, and seems to work reliably now. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70960/#review216198 ----------------------------------------------------------- On June 28, 2019, 1:11 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70960/ > ----------------------------------------------------------- > > (Updated June 28, 2019, 1:11 a.m.) > > > Review request for mesos, Greg Mann and Joseph Wu. > > > Bugs: MESOS-9860 > https://issues.apache.org/jira/browse/MESOS-9860 > > > Repository: mesos > > > Description > ------- > > This patch adds a test which confirms that the agent leaves a draining > state on its own once all frameworks on the agent have no more pending > tasks and all their executors have neither launched or queued tasks. > > The test uses the fact that the agent rejects task launches while > draining. > > > Diffs > ----- > > src/tests/slave_tests.cpp 7ba2df9fef9966cd09e0af3f4ef3bb260b6167f6 > > > Diff: https://reviews.apache.org/r/70960/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
