> On May 31, 2019, 10:31 a.m., Andrei Budnik wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 1099 (patched) > > <https://reviews.apache.org/r/70757/diff/1/?file=2147137#file2147137line1099> > > > > `PR_SET_NO_NEW_PRIVS` requires Linux kernel 3.5 (according to `man 2 > > prctl`). > > > > Minimum supported kernel version by Mesos is 2.6.28 - see > > http://mesos.apache.org/documentation/latest/building/#system-requirements > > > > There are at least 2 options to fix this problem: > > 1) bump the minimum kernel version to 3.5, if no one is against it on > > the dev/user list > > 2) remove `include <sys/prctl.h>` and define `PR_SET_NO_NEW_PRIVS` in > > the `containerizer/mesos/launch.cpp`. See > > https://github.com/apache/mesos/blob/fa410f2fb8efb988590f4da2d4cfffbb2ce70637/src/slave/containerizer/mesos/isolators/linux/seccomp.cpp#L35-L41 > > and > > https://github.com/seccomp/libseccomp/blob/78497a5d1da200ab0356e1189f5efb8724ad70a1/src/system.h#L94-L97 > > James Peach wrote: > To make a kernel version check, you can hoist `kernelVersion` from ns.cpp > into common code.
Cool, moved it up - Jacob ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70757/#review215611 ----------------------------------------------------------- On July 3, 2019, 11:30 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70757/ > ----------------------------------------------------------- > > (Updated July 3, 2019, 11:30 p.m.) > > > Review request for mesos, Andrei Budnik, Gilbert Song, Jie Yu, and James > Peach. > > > Bugs: MESOS-9770 > https://issues.apache.org/jira/browse/MESOS-9770 > > > Repository: mesos > > > Description > ------- > > This patch adds the isolation capability of flipping the > NO_NEW_PRIVILEGES bit for process control. > > > Diffs > ----- > > include/mesos/slave/containerizer.proto > 2d04f3c182a4274dda527a3da56c894c3c892a12 > src/CMakeLists.txt 1d4f541b73c07a307a8b61f217e0cfad5dc095e4 > src/Makefile.am 761dde1d63e0f4f1ac4ab86f129f84f3746d3153 > src/slave/containerizer/mesos/containerizer.cpp > 043244841a73fa3f5f7119bc38f6d3a04be8990b > src/slave/containerizer/mesos/isolators/linux/nnp.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/linux/nnp.cpp PRE-CREATION > src/slave/containerizer/mesos/launch.cpp > b29ec556399a40aa662987a11a2b64e6a16de889 > src/tests/CMakeLists.txt 3ea8b4400ff3b00470aa147cb8f39f62802727e3 > src/tests/containerizer/linux_nnp_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/70757/diff/2/ > > > Testing > ------- > > > Thanks, > > Jacob Janco > >
