----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71008/#review216432 -----------------------------------------------------------
src/master/master.cpp Lines 6238-6240 (patched) <https://reviews.apache.org/r/71008/#comment303667> Nit: I think we usually place the logical operators at the end of the preceding line, rather than the beginning of the next? src/master/master.cpp Lines 6251 (patched) <https://reviews.apache.org/r/71008/#comment303669> Newline before `.then` src/master/master.cpp Lines 6265 (patched) <https://reviews.apache.org/r/71008/#comment303670> Can we eliminate this temporary variable? - Greg Mann On July 3, 2019, 5:23 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71008/ > ----------------------------------------------------------- > > (Updated July 3, 2019, 5:23 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and > Vinod Kone. > > > Bugs: MESOS-9814 > https://issues.apache.org/jira/browse/MESOS-9814 > > > Repository: mesos > > > Description > ------- > > This adds logic in the master to detect when a DRAINING agent can > be transitioned into a DRAINED state. When this happens, the new > state is checkpointed into the registry and, if the agent is to be > marked "gone", the master will remove the agent. > > > Diffs > ----- > > src/master/master.hpp 23dafe746b6f9b3d70ad7220f54c4d49068b8af8 > src/master/master.cpp 5247377c2e7e92b9843dd4c9d28f92ba679ad742 > > > Diff: https://reviews.apache.org/r/71008/diff/2/ > > > Testing > ------- > > TODO: Need to write some unit tests. I'll want to rebase onto the agent > changes so that there is more detectable stuff in the tests. > > > Thanks, > > Joseph Wu > >