----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71008/#review216605 -----------------------------------------------------------
src/master/master.cpp Lines 6238-6241 (patched) <https://reviews.apache.org/r/71008/#comment303814> I feel it would make sense to log here (e.g., "Agent foobar is still draining"). We would hit the previous `if` even for any agent update while this one here would only be hit for draining agents (so we'd care about that additional bit of information). src/master/master.cpp Lines 6255-6260 (patched) <https://reviews.apache.org/r/71008/#comment303813> It seems we only do this check to make sure we can access the config below which introduces quite some coupling. Is there a reason we couldn't grab the config outside the lambda and capture it instead (i.e., do we want to support mutable drain configs)? That would allow us to reduce coupling between `Slave::draining` and `markGone`. src/master/master.cpp Lines 6269 (patched) <https://reviews.apache.org/r/71008/#comment303815> It would be nice to log here so we are able to see when draining is done. - Benjamin Bannier On July 12, 2019, 1:01 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71008/ > ----------------------------------------------------------- > > (Updated July 12, 2019, 1:01 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and > Vinod Kone. > > > Bugs: MESOS-9814 > https://issues.apache.org/jira/browse/MESOS-9814 > > > Repository: mesos > > > Description > ------- > > This adds logic in the master to detect when a DRAINING agent can > be transitioned into a DRAINED state. When this happens, the new > state is checkpointed into the registry and, if the agent is to be > marked "gone", the master will remove the agent. > > > Diffs > ----- > > src/master/http.cpp b42ebb953e0510e83ec6bd041cbddbeb8f60067c > src/master/master.hpp 23dafe746b6f9b3d70ad7220f54c4d49068b8af8 > src/master/master.cpp 5247377c2e7e92b9843dd4c9d28f92ba679ad742 > > > Diff: https://reviews.apache.org/r/71008/diff/4/ > > > Testing > ------- > > TODO: Need to write some unit tests. I'll want to rebase onto the agent > changes so that there is more detectable stuff in the tests. > > > Thanks, > > Joseph Wu > >
