----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71666/ -----------------------------------------------------------
(Updated Nov. 5, 2019, 7:41 p.m.) Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till Toenshoff. Changes ------- Adjusted shutdown logic to avoid deadlocks with the ProcessManager/SocketManager. (Basically, don't use process::loop here) Bugs: MESOS-10010 https://issues.apache.org/jira/browse/MESOS-10010 Repository: mesos Description ------- This completes a fully functional client-side SSL socket. Needs a bit of cleanup and more error handling though. Diffs (updated) ----- 3rdparty/libprocess/src/ssl/socket_wrapper.hpp PRE-CREATION 3rdparty/libprocess/src/ssl/socket_wrapper.cpp PRE-CREATION Diff: https://reviews.apache.org/r/71666/diff/4/ Changes: https://reviews.apache.org/r/71666/diff/3-4/ Testing (updated) ------- ``` cmake --build . --target libprocess-tests libprocess-tests ``` Running libprocess-tests yields: ``` [ FAILED ] SSLTest.ValidDowngrade [ FAILED ] SSLTest.ValidDowngradeEachProtocol [ FAILED ] Encryption/NetSocketTest.EOFBeforeRecv/0, where GetParam() = "SSL" [ FAILED ] Encryption/NetSocketTest.EOFAfterRecv/0, where GetParam() = "SSL" ``` Thanks, Joseph Wu