----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71735/#review218567 -----------------------------------------------------------
Ship it! Thanks for this. As for the formatting, personally I'd prefer whatever formatting our `clang-format` does, if only to remove the human element from this as much as possible. - Benjamin Bannier On Nov. 6, 2019, 3:35 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71735/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2019, 3:35 p.m.) > > > Review request for mesos, Benjamin Bannier and Greg Mann. > > > Repository: mesos > > > Description > ------- > > Added the `[[nodiscard]]` attribute to `Resources::pushReservation()` > and `Resources::popReservation()`, in order to prevent mistakes by > authors incorrectly assuming that these functions would modify the > resources objects in place. > > > Diffs > ----- > > include/mesos/resources.hpp b8aef28e08f85c87bb78f25a64b0d7318f2727cc > > > Diff: https://reviews.apache.org/r/71735/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
