----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71735/ -----------------------------------------------------------
(Updated Nov. 7, 2019, 2:37 p.m.) Review request for mesos, Benjamin Bannier and Greg Mann. Changes ------- Reformatted line breaks. Summary (updated) ----------------- Added 'nodiscard' attribute to some member functions of Resources. Repository: mesos Description ------- Added the `[[nodiscard]]` attribute to `Resources::pushReservation()` and `Resources::popReservation()`, in order to prevent mistakes by authors incorrectly assuming that these functions would modify the resources objects in place. Diffs (updated) ----- include/mesos/resources.hpp b8aef28e08f85c87bb78f25a64b0d7318f2727cc Diff: https://reviews.apache.org/r/71735/diff/2/ Changes: https://reviews.apache.org/r/71735/diff/1-2/ Testing ------- Thanks, Benno Evers
