> On Feb. 27, 2020, 4:59 p.m., Benjamin Bannier wrote: > > Is the plan to upstream this patch? We usually try to enable building > > against unbundled dependencies and depending on custom behavior makes that > > impossible. My hunch would be to not make functional changes like the one > > in this patch to dependencies (changes for building are usually fine).
Yea, attempting to upstream is a good idea. Qian would you like to open a PR, or would you like me to? https://github.com/Tencent/rapidjson - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72161/#review219677 ----------------------------------------------------------- On March 2, 2020, 6:27 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72161/ > ----------------------------------------------------------- > > (Updated March 2, 2020, 6:27 a.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10064 > https://issues.apache.org/jira/browse/MESOS-10064 > > > Repository: mesos > > > Description > ------- > > This commit updates the writer of RapidJSON to write infinite > floating point numbers as "Infinity" and "-Infinity" (i.e., > with double quotes) rather than Infinity and -Infinity. This > is to ensure the strings converted from JSON objects conform > to the rule defined by Protobuf: > https://developers.google.com/protocol-buffers/docs/proto3#json > > > Diffs > ----- > > 3rdparty/CMakeLists.txt c45d742684ba4b3b4abc57ae0bcb85a879c68bfd > 3rdparty/rapidjson-1.1.0.patch PRE-CREATION > > > Diff: https://reviews.apache.org/r/72161/diff/2/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
