----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/#review219804 -----------------------------------------------------------
src/tests/containerizer/cgroups_isolator_tests.cpp Lines 716 (patched) <https://reviews.apache.org/r/71983/#comment308034> s/memory's/memory/ src/tests/containerizer/cgroups_isolator_tests.cpp Lines 961 (patched) <https://reviews.apache.org/r/71983/#comment308035> This looks racy; we shouldn't rely on the running wall clock to trigger offers in a test like this. Could you pause the clock and advance manually to trigger offers? There are some existing examples in the tests of this; you could check 'SchedulerTest.OperationFeedbackValidationWithResourceProviderCapability'. - Greg Mann On Jan. 13, 2020, 8:06 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71983/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2020, 8:06 a.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10050 > https://issues.apache.org/jira/browse/MESOS-10050 > > > Repository: mesos > > > Description > ------- > > Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`. > > > Diffs > ----- > > src/tests/containerizer/cgroups_isolator_tests.cpp > f72e6cdab417368e63349915114aeed586e0ef0e > > > Diff: https://reviews.apache.org/r/71983/diff/2/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
