> On March 19, 2020, 11:15 a.m., Greg Mann wrote: > > src/tests/containerizer/cgroups_isolator_tests.cpp > > Lines 1177 (patched) > > <https://reviews.apache.org/r/71983/diff/7/?file=2214141#file2214141line1177> > > > > Could you move this to the end of the test so we're just paused for the > > entire test body?
I tried it, but this test will fail: ``` ../../src/tests/containerizer/cgroups_isolator_tests.cpp:1263: Failure Failed to wait 15secs for killedUpdate1 ``` I think that is because default executor uses `delay()` to wait 3 seconds for task to terminate (https://github.com/apache/mesos/blob/1.9.0/src/launcher/default_executor.cpp#L1153:L1163 ), if we do not call `Clock::resume()`, then that delay() may not work as we expect: ``` I0319 03:26:25.972328 41296 default_executor.cpp:1171] Scheduling escalation to SIGKILL in 3secs from now I0319 03:26:25.974565 41219 http.cpp:1405] HTTP POST for /slave(1)/api/v1 from 10.0.50.220:51150 I0319 03:26:25.974958 41219 http.cpp:3651] Processing KILL_NESTED_CONTAINER call for container 'fd32e39c-f362-4d58-a364-c2f9a8e1fea2.6c77f255-cfb5-4c19-b37c-a7a6fd7d0eec' I0319 03:26:25.975901 41220 containerizer.cpp:3027] Sending Terminated to container fd32e39c-f362-4d58-a364-c2f9a8e1fea2.6c77f255-cfb5-4c19-b37c-a7a6fd7d0eec in RUNNING state I0319 03:26:28.973389 41338 default_executor.cpp:1249] Task 'f3873537-a8ec-4328-874a-2fec0f5daffb' running in child container fd32e39c-f362-4d58-a364-c2f9a8e1fea2.6c77f255-cfb5-4c19-b37c-a7a6fd7d0eec did not terminate after 3secs, sending SIGKILL to the container ``` - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/#review219993 ----------------------------------------------------------- On March 18, 2020, 10:54 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71983/ > ----------------------------------------------------------- > > (Updated March 18, 2020, 10:54 p.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10050 > https://issues.apache.org/jira/browse/MESOS-10050 > > > Repository: mesos > > > Description > ------- > > Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`. > > > Diffs > ----- > > src/tests/containerizer/cgroups_isolator_tests.cpp > f72e6cdab417368e63349915114aeed586e0ef0e > > > Diff: https://reviews.apache.org/r/71983/diff/7/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
