> On March 15, 2020, 2:05 p.m., Qian Zhang wrote: > > src/slave/validation.cpp > > Lines 460-465 (patched) > > <https://reviews.apache.org/r/72221/diff/2/?file=2213594#file2213594line465> > > > > Why do we need this check?
I removed this. > On March 15, 2020, 2:05 p.m., Qian Zhang wrote: > > src/slave/validation.cpp > > Lines 467-472 (patched) > > <https://reviews.apache.org/r/72221/diff/2/?file=2213594#file2213594line472> > > > > I think here what you check is the resource requests, but we also need > > to ensure no resource limits specified for such containers, and also > > mention in the error message that such containers cannot have > > `share_cgroup` as false. Done. > On March 15, 2020, 2:05 p.m., Qian Zhang wrote: > > src/slave/validation.cpp > > Lines 473-479 (patched) > > <https://reviews.apache.org/r/72221/diff/2/?file=2213594#file2213594line478> > > > > Why do we need this check? I think we should allow launching 1st level > > nested container with resource requests specified and `share_cgroups` as > > true, right? That's actually what the default executor does in our current > > implementation. Removed this. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72221/#review219940 ----------------------------------------------------------- On March 19, 2020, 2:11 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72221/ > ----------------------------------------------------------- > > (Updated March 19, 2020, 2:11 a.m.) > > > Review request for mesos, Andrei Budnik and Qian Zhang. > > > Bugs: MESOS-10045 > https://issues.apache.org/jira/browse/MESOS-10045 > > > Repository: mesos > > > Description > ------- > > Added agent validation for shared cgroups. > > > Diffs > ----- > > src/slave/validation.cpp 99b17c965d4cc522e9106078a9e6f34fae396b8a > > > Diff: https://reviews.apache.org/r/72221/diff/3/ > > > Testing > ------- > > > Thanks, > > Greg Mann > >
