----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72221/#review220030 -----------------------------------------------------------
Fix it, then Ship it! src/slave/validation.cpp Lines 492 (patched) <https://reviews.apache.org/r/72221/#comment308294> Why do we need this line? To backward compatible with how standalone containers are launched currently? - Qian Zhang On March 20, 2020, 8:36 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72221/ > ----------------------------------------------------------- > > (Updated March 20, 2020, 8:36 a.m.) > > > Review request for mesos, Andrei Budnik and Qian Zhang. > > > Bugs: MESOS-10045 > https://issues.apache.org/jira/browse/MESOS-10045 > > > Repository: mesos > > > Description > ------- > > Added agent validation for shared cgroups. > > > Diffs > ----- > > src/slave/validation.cpp 99b17c965d4cc522e9106078a9e6f34fae396b8a > > > Diff: https://reviews.apache.org/r/72221/diff/5/ > > > Testing > ------- > > > Thanks, > > Greg Mann > >