----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72304/#review220221 -----------------------------------------------------------
Patch looks great! Reviews applied: [72273, 72285, 72286, 72303, 72304] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbot On April 1, 2020, 11:55 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72304/ > ----------------------------------------------------------- > > (Updated April 1, 2020, 11:55 p.m.) > > > Review request for mesos, Andrei Sekretenko and Greg Mann. > > > Repository: mesos > > > Description > ------- > > The os/shell.hpp wrapper provides a single place to read the interface > and documentation for both POSIX and Windows, this makes it easier > for us to document the interface and OS differences that a caller > needs to know about in one place. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/shell.hpp > 2cc4e2cd206e9d91541dfad1e7eb2da213188420 > 3rdparty/stout/include/stout/os/shell.hpp > 33cc8a672a8edc46478ad57a01a20ed90acf40ad > 3rdparty/stout/include/stout/os/windows/shell.hpp > 2f76bbaac9032906c544010c55cdcbe3d7b03d23 > > > Diff: https://reviews.apache.org/r/72304/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
