Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2851#discussion_r24672255
  
    --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
    @@ -91,6 +91,7 @@ private[spark] object JsonProtocol {
             executorRemovedToJson(executorRemoved)
           // These aren't used, but keeps compiler happy
           case SparkListenerExecutorMetricsUpdate(_, _) => JNothing
    +      case SparkListenerBlockUpdate(_, _, _) => JNothing
    --- End diff --
    
    This event should be converted to json so it can be seen in the UI for 
completed apps.  You need to implement serialization here, and also 
deserialization in `sparkEventFromJson`, as that is used by `ReplayListenerBus` 
to show the UI for completed apps.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to