Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/2851#discussion_r24673367
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterActor.scala ---
@@ -466,10 +467,11 @@ private[spark] class BlockManagerInfo(
storageLevel: StorageLevel,
memSize: Long,
diskSize: Long,
- tachyonSize: Long) {
+ tachyonSize: Long): BlockStatus = {
- updateLastSeenMs()
+ var blockStatus: BlockStatus = null
--- End diff --
we can get rid of this var -- just have each branch of the if/else finish
w/ the block status you want to return.
```
if (_blocks.containsKey(blockId)) {
...
if (storageLevel.isValid) {
...
_blocks.get(blockId)
} else if (_blocks.containsKey(blockId)) {//I realize you aren't
modifying this part, but isn't this condition redundant?
val blockStatus: BlockStatus = _blocks.get(blockId)
...
BlockStatus(storageLevel, 0, 0, 0)
}
} else {
null
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
