linzebing commented on issue #27223: [SPARK-30511][CORE] Spark marks ended speculative tasks as pending leads to holding idle executors URL: https://github.com/apache/spark/pull/27223#issuecomment-575253478 @Ngone51 : Let's say we have one speculative task. When a speculative task gets intentionally killed because the original task succeeds, then `pendingSpeculativeTasks` will be 1. However, it should be zero. In my PR, the two data structures are given a very clear meaning: `stageAttemptToNumSpeculativeTasks`: all the pending and running speculative tasks `stageAttemptToSpeculativeTaskIndices`: task indexes of all the running speculative tasks. But thanks for pointing out, I'm editing the PR description to be more accurate.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
