Ngone51 commented on a change in pull request #27223: [SPARK-30511][CORE] Spark marks intentionally killed speculative tasks as pending leads to holding idle executors URL: https://github.com/apache/spark/pull/27223#discussion_r367750785
########## File path: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ########## @@ -614,18 +614,24 @@ private[spark] class ExecutorAllocationManager( stageAttemptToNumRunningTask -= stageAttempt } } - // If the task failed, we expect it to be resubmitted later. To ensure we have - // enough resources to run the resubmitted task, we need to mark the scheduler - // as backlogged again if it's not already marked as such (SPARK-8366) - if (taskEnd.reason != Success) { - if (totalPendingTasks() == 0) { - allocationManager.onSchedulerBacklogged() - } - if (taskEnd.taskInfo.speculative) { - stageAttemptToSpeculativeTaskIndices.get(stageAttempt).foreach {_.remove(taskIndex)} - } else { - stageAttemptToTaskIndices.get(stageAttempt).foreach {_.remove(taskIndex)} - } + + if (taskEnd.taskInfo.speculative) { Review comment: I think `stageAttemptToSpeculativeTaskIndices` also includes successful finished speculative tasks? Remove a successful speculative task will count it into pending speculative tasks again. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org