Github user squito commented on the pull request:
https://github.com/apache/spark/pull/2851#issuecomment-74698831
Hi @CodingCat
thanks for making all the updates. Sorry I hadn't realized the subtlety w/
`Int` vs `Long` on the `RDDBlockId` and `BroadcastBlockId`. Still, I think its
still a good change for simplifying the code, glad you figured a way to make it
work. And on issue (2), the memory usage of a worker, I think what you have
is correct, its supposed to be memory usage of the particular object on the
worker. This is on a UI page in the context of a particular object -- there is
a separate page to summarize the memory usage of the executor overall. (though
I agree the UI is a little confusing ...)
I'll make a few more minor comments on the code, but mostly I just want to
get another opinion on the right events to pass the block added events around,
as I have mentioned above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
