Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/2851#discussion_r24830276
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SparkListenerBus.scala ---
@@ -24,7 +24,13 @@ import org.apache.spark.util.ListenerBus
*/
private[spark] trait SparkListenerBus extends ListenerBus[SparkListener,
SparkListenerEvent] {
+ private[spark] var filter: DefaultSparkListenerEventFilter = new
DefaultSparkListenerEventFilter
+
override def onPostEvent(listener: SparkListener, event:
SparkListenerEvent): Unit = {
+ if (!filter.validate(event)) {
+ return
--- End diff --
also, I think there is still one missing piece to get the json into the
event logging for the history server. You need to implement to put in the
implementation for `onBlockUpdate` in `EventLoggingListener`. I am suggesting
that you just put this filter into that implementation, and get rid of the
`Filter` abstraction.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
