HyukjinKwon commented on a change in pull request #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#discussion_r375009397
##########
File path:
sql/core/src/test/resources/sql-tests/inputs/postgreSQL/window_part2.sql
##########
@@ -15,6 +15,18 @@ CREATE TABLE empsalary (
enroll_date date
) USING parquet;
+INSERT INTO empsalary VALUES
Review comment:
I see one case being tested against `empsalary`
```sql
select last(salary) over(order by salary range between 1000 preceding and
1000 following),
lag(salary) over(order by salary range between 1000 preceding and 1000
following),
salary from empsalary;
```
```
-- !query
select last(salary) over(order by salary range between 1000 preceding and
1000 following),
lag(salary) over(order by salary range between 1000 preceding and 1000
following),
salary from empsalary
-- !query schema
struct<>
-- !query output
org.apache.spark.sql.AnalysisException
Window Frame specifiedwindowframe(RangeFrame, -1000, 1000) must match the
required frame specifiedwindowframe(RowFrame, -1, -1);
```
This isn't supported. Can you comment it out and make a followup JIRA?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
