HyukjinKwon commented on a change in pull request #27439:
[SPARK-29108][SQL][TESTS][FOLLOWUP] Add insert sql to window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#discussion_r375009659
##########
File path:
sql/core/src/test/resources/sql-tests/inputs/postgreSQL/window_part2.sql
##########
@@ -15,6 +15,18 @@ CREATE TABLE empsalary (
enroll_date date
) USING parquet;
+INSERT INTO empsalary VALUES
+ ('develop', 10, 5200, date '2007-08-01'),
+ ('sales', 1, 5000, date '2006-10-01'),
+ ('personnel', 5, 3500, date '2007-12-10'),
+ ('sales', 4, 4800, date '2007-08-08'),
+ ('personnel', 2, 3900, date '2006-12-23'),
+ ('develop', 7, 4200, date '2008-01-01'),
+ ('develop', 9, 4500, date '2008-01-01'),
+ ('sales', 3, 4800, date '2007-08-01'),
+ ('develop', 8, 6000, date '2006-10-01'),
+ ('develop', 11, 5200, date '2007-08-15');
Review comment:
Once https://github.com/apache/spark/pull/27439/files#r375009397 is
addressed, there's no point of creating this table anymore because it's used
nowhere. I think you can comment out both CREATE and INSERT, with commenting
it's currently not used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
