Ngone51 commented on a change in pull request #27604: [SPARK-30849][CORE][SHUFFLE]Fix application failed due to failed to get MapStatuses broadcast block URL: https://github.com/apache/spark/pull/27604#discussion_r382412090
########## File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ########## @@ -824,11 +825,15 @@ private[spark] class MapOutputTrackerWorker(conf: SparkConf) extends MapOutputTr endPartition: Int): Iterator[(BlockManagerId, Seq[(BlockId, Long, Int)])] = { logDebug(s"Fetching outputs for shuffle $shuffleId, mappers $startMapIndex-$endMapIndex" + s"partitions $startPartition-$endPartition") - val statuses = getStatuses(shuffleId, conf) try { + val statuses = getStatuses(shuffleId, conf) Review comment: I'd prefer to add another try catch when we call `broadcast.vaule` at: https://github.com/apache/spark/blob/a2aa966ef64bc06f65a646777568427d360605e9/core/src/main/scala/org/apache/spark/MapOutputTracker.scala#L969 and throw `FetchFailedException` when we catch `SparkException` from broadcast. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org